Skip to content

[Vendor] update golang.org/x/crypto#12481

Merged
techknowlogick merged 2 commits into
go-gitea:masterfrom
6543-forks:update_vendor_crypto
Aug 13, 2020
Merged

[Vendor] update golang.org/x/crypto#12481
techknowlogick merged 2 commits into
go-gitea:masterfrom
6543-forks:update_vendor_crypto

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented Aug 13, 2020

as title

@6543 6543 mentioned this pull request Aug 13, 2020
Closed
2 tasks
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 13, 2020
@CirnoT
Copy link
Copy Markdown
Contributor

CirnoT commented Aug 13, 2020

Approving due to change in SSH client-auth, tho unsure if we are even using that part of code in our SSH implementation.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #12481 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12481      +/-   ##
==========================================
+ Coverage   43.77%   43.80%   +0.03%     
==========================================
  Files         631      631              
  Lines       69851    69851              
==========================================
+ Hits        30576    30597      +21     
+ Misses      34325    34312      -13     
+ Partials     4950     4942       -8
Impacted Files Coverage Δ
modules/git/submodule.go 74.00% <100.00%> (ø)
services/pull/update.go 51.92% <0.00%> (-5.77%) ⬇️
modules/queue/workerpool.go 60.00% <0.00%> (-2.05%) ⬇️
services/pull/temp_repo.go 29.78% <0.00%> (ø)
models/issue.go 57.14% <0.00%> (+0.35%) ⬆️
modules/notification/webhook/webhook.go 48.95% <0.00%> (+0.52%) ⬆️
services/pull/pull.go 43.41% <0.00%> (+0.69%) ⬆️
modules/git/repo.go 52.79% <0.00%> (+1.01%) ⬆️
modules/git/command.go 90.19% <0.00%> (+1.96%) ⬆️
services/pull/patch.go 68.96% <0.00%> (+2.58%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01bac8...6af55ff. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 13, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 13, 2020
@techknowlogick techknowlogick added dependencies skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 13, 2020
@techknowlogick
Copy link
Copy Markdown
Member

techknowlogick commented Aug 13, 2020

🚀

@techknowlogick techknowlogick merged commit e266ba3 into go-gitea:master Aug 13, 2020
@techknowlogick techknowlogick deleted the update_vendor_crypto branch August 13, 2020 15:57
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@CirnoT CirnoT CirnoT approved these changes

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

7 participants

@6543 @CirnoT @codecov-commenter @techknowlogick @sapk @GiteaBot @zeripath